The conversation

Lessons learnedExperience excerpt · English

I can tell you how that situation comes about

I can tell you how that situation comes about. You start by rejecting those PRs, saying "write more maintainable code, not quick hacks". Management starts pressuring the original developer "why is it not merged yet, I thought you had it working". That developer hits back with "well, it failed code review, they want me to refactor it". Management goes back to the reviewer, "why did you fail this? It meets coding standards right? Pipeline is green". Reviewer says "Well, yes it technically meets coding standards but it's full of hacks and is not future proof, it will bite us." Management says "If we coded for tomorrow we'd never get anything done. Don't be so awkward". And then code gets merged. Then you learn to just let these people go wild. If it hurts in the future you have a nice little "I told you so". But in my experience, management doesn't actually care if it hurts us in the future, it's not their problem. They just say "Well give me bigger estimates if you need to refactor". Fair enough, it's not a big deal but it is a pointless slog of picking up the pieces. …

Original discussionThe Wonders of AI: We Are Retiring Our Bug Bounty Program285 source comments · at import
2

What was this responding to?

Parent context · original excerpt

HN

I have seen precisely zero consequences for these people because they usually leave after not too long and go somewhere else, sometimes for higher pay. The slower folks end up getting the worse code and no raises in exchange for comradery. But also I have no idea how that situation arises unless the slower folks are just auto-approving PRs. You kind of did that to yourself if you let the new person get away with it.

Full original

Community replies 0

No community replies yet. Add your perspective.

Replies from the source 2

Direct replies available in this import. Original-language excerpts.

AL

>You start by rejecting those PRs, saying "write more maintainable code, not quick hacks". How do you go about that when for example, my previous employer just allowed any software developer to commit to any branch, and there was never any code review happening?

Full original
PE

wow, that's a charitable take IME the manager just approves the PR themself to "bias for action", someone else will pick up the pieces

Full original
Continue on Hacker News

Respect different perspectives. Share concrete experiences.

Sign in to post, reply, repost, and quote.